fix: resolve_hostname endianness on little-endian MIPS#21
Merged
AndrewAltimit merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
sceNetResolverStartNtoA stores the IP in network byte order (big-endian) in memory. On little-endian MIPS (PSP), reading the in_addr as a u32 gives a byte-swapped value. Using to_be_bytes() then double-swaps, producing reversed IPs (e.g., 207.241.224.2 becomes 2.224.241.207). to_ne_bytes() returns the raw memory bytes, which are already in the correct network byte order for sockaddr_in. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gemini AI Code ReviewIssues (if any)(none) Previous Issues (for incremental reviews)(none) Suggestions (if any)(none) Notes
Generated by Gemini AI (gemini-3-flash-preview). Supplementary to human reviews. |
Owner
Author
Review Response Agent (Iteration 1)Status: No changes needed Fixed Issues
Ignored Issues
Deferred to Human
Notes
The agent reviewed feedback but determined no code changes were required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_hostnameusedto_be_bytes()on the u32 IP returned bysceNetResolverStartNtoA, which double-swaps the bytes on little-endian MIPS (PSP Allegrex)to_be_bytes()swaps again, reversing the IP (e.g.207.241.224.2becomes2.224.241.207)to_ne_bytes()returns the raw memory bytes, which are already in the correct network orderVerified on hardware
Test plan
Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com